Re: [PATCH v1 1/5] scripts: Add sortextable to sort the kernel'sexception table.

[David Daney]

On 04/20/2012 07:59 AM, Sam Ravnborg wrote:
> On Thu, Apr 19, 2012 at 02:59:55PM -0700, David Daney wrote:
> > From: David Daney<david.daney@xxxxxxxxxx>
> >
> > Using this build-time sort saves time booting as we don't have to burn
> > cycles sorting the exception table.
> >
> > Signed-off-by: David Daney<david.daney@xxxxxxxxxx>
> > ---
> >   scripts/.gitignore    |    1 +
> >   scripts/Makefile      |    1 +
> >   scripts/sortextable.c |  273 +++++++++++++++++++++++++++++++++++++++++++++++++
> >   scripts/sortextable.h |  168 ++++++++++++++++++++++++++++++
>
> If there is only a single file including the .h file - then there is no gain.
> Just fold it into the .c file.

s/single file/single site/, and I am in complete agreement.  However 
this patch doesn't meet that criterion.  In this particular case, there 
is more to the patch than just the diffstat.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/