Re: [patch] tracing: Remove an unneeded check

From: Steven Rostedt
Date: Fri Apr 20 2012 - 10:26:11 EST

On Fri, 2012-04-20 at 17:03 +0300, Dan Carpenter wrote:
> On Fri, Apr 20, 2012 at 09:51:21AM -0400, Steven Rostedt wrote:
> > On Fri, 2012-04-20 at 09:31 +0300, Dan Carpenter wrote:
> > > memcpy() returns a pointer to "bug". Hopefully, it's not NULL here or
> > > we would already have Oopsed.
> >
> > You're right that the ret is useless, and the real bug was already fixed
> > (the possibility that buf could be an invalid pointer).
> >
> > Not only is this needed, but also get rid of the ret < 0 check in
> > tracing_splice_read_pipe().
> >
> We still return -EBUSY so we need the check.

Hmm, you're right. I need to take a deeper look at this code. It looks
like it can be cleaned up a bit more (the splice code).

OK, your patch is good as is. I'll add it in my 3.5 queue, and add a
mental note to look at this code again.


-- Steve

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at