Re: [PATCH 1/2] HID: hid-lg4ff: Add support for G27 LEDs

From: Jiri Kosina
Date: Fri Apr 20 2012 - 06:05:25 EST

On Wed, 18 Apr 2012, simon@xxxxxxxxxxxxx wrote:

> > Putting the whole err: label outside the outer for cycle would make the
> > whole thing much more readable (and would save you the break). Could you
> > please redo this?
> The 'break' is actually not needed as 'j' has reached maximum value and
> the outer for loop would be at completion.

Ah, right, I have even missed this fact, that you are using the same index
in the inner loop as in the outter loop.

Quite unreadable indeed :)

> I put the 'break' there just to highlight this fact.
> Maybe just a comment would be OK, such as 'on error fall though to driver
> completion'.
> The reason I'd like this code here is that it seems traditional to output
> the following 'hid_info' line once the driver is fully active.
> >> hid_info(hid, "Force feedback for Logitech Speed Force Wireless by
> >> Simon Wood <simon@xxxxxxxxxxxxx>\n");
> Moving the 'err:' code would have to:
> 1). Jump back to hit this hid_info line
> 2). Duplicate the hid_info line
> 3). Have err code called as a function

I am not getting it. Why can't you do just something like

for ( .... ) {
/* outter loop */
if (error) {
for ( ... ) {
/* inner loop */
goto out;

Jiri Kosina
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at