Re: [PATCH v4 3/3] cred: change keyctl_session_to_parent() to usetask_work_add()

From: Oleg Nesterov
Date: Thu Apr 19 2012 - 15:48:17 EST

On 04/19, David Howells wrote:
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> > I am not going to argue, but honestly I don't think it is a good
> > idea to mix the functional changes in keyctl.c and the simple
> > (but obviously untested) cleanups.
> I meant add the cleanup as patch 4. That way they are still separate. I'll
> let you change the name of the function to make it easier;-)


I'd like to avoid the unnecessary resends, lets discuss this before
I send the patch(es).

At least I'd like to split this into 2 patches:

4/3: only removes the dead code from arch/*

5/3: updates copy_creds/exit_creds and kills
->replacement_session_keyring, plus renames
key_change_ back to key_replace_

Do you agree?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at