Re: [PATCH v2] smb347_charger: Cleanup power supply registrationcode in probe

From: Mika Westerberg
Date: Thu Apr 19 2012 - 15:09:15 EST


On Thu, Apr 19, 2012 at 10:00:18AM +0530, Ramakrishna Pallala wrote:
> This patch checks if the usb or mains charging is enabled by the
> platform before registering with the power supply class.

I still don't like the idea of having the power-supplies registered
conditionally. Now you need to check in every place whether the corresponding
power-supply is registered or not which makes the code uglier and more prone
to errors.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/