Re: [PATCH v4 3/3] cred: change keyctl_session_to_parent() to usetask_work_add()

From: Oleg Nesterov
Date: Thu Apr 19 2012 - 13:35:19 EST

On 04/19, David Howells wrote:
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> > +#define key_replace_session_keyring() do { } while (0)
> > +
> Ummm... Why? You've made the function no longer exist and so this shouldn't be
> there anymore. You shouldn't just leave the call sites in place.


I'll send the (trivial) patches to cleanup the code in arch/ (24 callers),
plus we should kill the no longer used task ->replacement_session_keyring
and update copy_creds/exit_creds.

But I certainly do not want to put these changes in 3/3 or in this series.
I'll send the patches to Andrew once (I hope ;) he takes 1-3.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at