RE: [PATCH] smb347_charger: Cleanup power supply registration codein probe

[Pallala, Ramakrishna]

> Sent: Thursday, April 19, 2012 12:41 PM
> To: Pallala, Ramakrishna
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Anton Vorontsov; Anton Vorontsov
> Subject: Re: [PATCH] smb347_charger: Cleanup power supply registration code in probe
> 
> On Fri, Apr 13, 2012 at 03:14:52PM +0530, Ramakrishna Pallala wrote:
> > This patch checks if the usb or mains charging is enabled by the
> > platform before registering with the power supply class.
> 
> Can you describe why this change is needed? The current code always registers all the
> power-supplies but if we haven't enabled for example USB charging, then the online
> property for USB ps is set to 0.

If we haven't enabled USB charging then why to waste kernel resources?
What we will gain by registering with power supply class if USB charging is not enabled?

Thanks,
Ram


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/