Re: [PATCH] HID: hid-input: default HID_BATTERY_STRENGTH to no

From: Jiri Kosina
Date: Wed Apr 18 2012 - 13:28:43 EST

On Wed, 18 Apr 2012, Matthew Garrett wrote:

> > Matthew suggested that additional kernel patches were required to add a
> > scope parameter so upower could understand that the battery is powering
> > a device and not the system.
> >
> > Also, when did it become OK to force-enable a new feature that is
> > _known_ to not work properly on recent userspace? That makes no sense
> > to me.
> I agree. It's a great feature, but it shouldn't be default y if
> userspace isn't ready for it yet.

Fully agreed, the 'default y' part escaped my attention. I will be
applying the patch and pushing out to Linus.

I even wonder whether we shouldn't put a warning into the Kconfig entry,
explaining the consequences of having userspace not ready for the feature.

Jiri Kosina
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at