Re: [v3.4-rc1] ACPI regression bisected

From: Linus Torvalds
Date: Wed Apr 18 2012 - 13:24:45 EST


On Wed, Apr 18, 2012 at 3:29 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> Linus, can you please apply directly?

Applied. Can we perhaps also make request_threaded_irq() noisily
reject things that are not marked IRQF_ONESHOT and have a NULL
low-level handler?

That still allows people to do IRQF_SHARED | IRQF_ONESHOT, and that
won't be rejected until somebody else actually tries to share it. Then
it breaks that somebody else ;(

Sadly, that would tend to break fairly silently.

I wonder if we should make the mismatch error printout be
unconditional (and make just the "dump_stack()" part be conditional on
CONFIG_DEBUG_SHIRQ)?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/