Re: [PATCH 1/1] Remove UBIFS_FS_XATTR config option.

[Subodh Nijsure]

Any chance I can get feedback on this, so I can send out V3 of my
extended attribute patch.

Regards,
-Subodh

On Sat, Apr 14, 2012 at 9:09 AM, Subodh Nijsure
<subodh.nijsure@xxxxxxxxx> wrote:
> Remove CONFIG_UBIFS_FS_XATTR configuration option and associated
> UBIFS_FS_XATTR ifdefs.
>
> Testing:
> Â Â Â Tested using integck while using nandsim on x86 & MX28 based
> Â Â Â platform with Micron MT29F2G08ABAEAH4 nand.
>
> Signed-off-by: Subodh Nijsure <snijsure@xxxxxxxxxxxx>
> ---
> Âfs/ubifs/Kconfig  |  Â6 ------
> Âfs/ubifs/Makefile Â| Â Â3 +--
> Âfs/ubifs/dir.c   |  Â2 --
> Âfs/ubifs/file.c  Â|  Â2 --
> Âfs/ubifs/journal.c | Â Â2 --
> Â5 files changed, 1 insertions(+), 14 deletions(-)
>
> diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
> index f8b0160..e49a23c 100644
> --- a/fs/ubifs/Kconfig
> +++ b/fs/ubifs/Kconfig
> @@ -11,12 +11,6 @@ config UBIFS_FS
> Â Â Â Âhelp
> Â Â Â Â ÂUBIFS is a file system for flash devices which works on top of UBI.
>
> -config UBIFS_FS_XATTR
> - Â Â Â bool "Extended attributes support"
> - Â Â Â depends on UBIFS_FS
> - Â Â Â help
> - Â Â Â Â This option enables support of extended attributes.
> -
> Âconfig UBIFS_FS_ADVANCED_COMPR
> Â Â Â Âbool "Advanced compression options"
> Â Â Â Âdepends on UBIFS_FS
> diff --git a/fs/ubifs/Makefile b/fs/ubifs/Makefile
> index 80e93c3..4878614 100644
> --- a/fs/ubifs/Makefile
> +++ b/fs/ubifs/Makefile
> @@ -3,7 +3,6 @@ obj-$(CONFIG_UBIFS_FS) += ubifs.o
> Âubifs-y += shrinker.o journal.o file.o dir.o super.o sb.o io.o
> Âubifs-y += tnc.o master.o scan.o replay.o log.o commit.o gc.o orphan.o
> Âubifs-y += budget.o find.o tnc_commit.o compress.o lpt.o lprops.o
> -ubifs-y += recovery.o ioctl.o lpt_commit.o tnc_misc.o
> +ubifs-y += recovery.o ioctl.o lpt_commit.o tnc_misc.o xattr.o
>
> Âubifs-$(CONFIG_UBIFS_FS_DEBUG) += debug.o
> -ubifs-$(CONFIG_UBIFS_FS_XATTR) += xattr.o
> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
> index ec9f187..ad6e550 100644
> --- a/fs/ubifs/dir.c
> +++ b/fs/ubifs/dir.c
> @@ -1187,12 +1187,10 @@ const struct inode_operations ubifs_dir_inode_operations = {
>    Â.rename   Â= ubifs_rename,
>    Â.setattr   = ubifs_setattr,
>    Â.getattr   = ubifs_getattr,
> -#ifdef CONFIG_UBIFS_FS_XATTR
>    Â.setxattr  Â= ubifs_setxattr,
>    Â.getxattr  Â= ubifs_getxattr,
>    Â.listxattr  = ubifs_listxattr,
> Â Â Â Â.removexattr = ubifs_removexattr,
> -#endif
> Â};
>
> Âconst struct file_operations ubifs_dir_operations = {
> diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
> index 5c8f6dc..0fe640c 100644
> --- a/fs/ubifs/file.c
> +++ b/fs/ubifs/file.c
> @@ -1562,12 +1562,10 @@ const struct address_space_operations ubifs_file_address_operations = {
> Âconst struct inode_operations ubifs_file_inode_operations = {
>    Â.setattr   = ubifs_setattr,
>    Â.getattr   = ubifs_getattr,
> -#ifdef CONFIG_UBIFS_FS_XATTR
>    Â.setxattr  Â= ubifs_setxattr,
>    Â.getxattr  Â= ubifs_getxattr,
>    Â.listxattr  = ubifs_listxattr,
> Â Â Â Â.removexattr = ubifs_removexattr,
> -#endif
> Â};
>
> Âconst struct inode_operations ubifs_symlink_inode_operations = {
> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
> index 2f438ab..bc75e9d 100644
> --- a/fs/ubifs/journal.c
> +++ b/fs/ubifs/journal.c
> @@ -1267,7 +1267,6 @@ out_free:
> Â Â Â Âreturn err;
> Â}
>
> -#ifdef CONFIG_UBIFS_FS_XATTR
>
> Â/**
> Â* ubifs_jnl_delete_xattr - delete an extended attribute.
> @@ -1462,4 +1461,3 @@ out_free:
> Â Â Â Âreturn err;
> Â}
>
> -#endif /* CONFIG_UBIFS_FS_XATTR */
> --
> 1.7.5.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/