Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensorisl29018 support

From: Laxman Dewangan
Date: Wed Apr 18 2012 - 03:04:08 EST

On Wednesday 18 April 2012 04:05 AM, Stephen Warren wrote:
On 04/17/2012 12:45 AM, Laxman Dewangan wrote:
Add the device info for ALS and proximity sensor isl29018.
+ isl29018: isl29018@44 {
I don't think the label "isl29018:" serves any purpose; nothing else
needs to refer to this node.

I note from that:

a) Perhaps the vendor prefix should be "isil" not "isl". Olof, can you
please comment here?

b) There's an interrupt signal connected to the device. Can you please
add that, irrespective of whether the driver uses it.

Will do.
c) This device is also present on Seaboard. Can you update
tegra-seaboard.dts too? You can find the relevant bus from the link above.

Will do.

I will wait for finalizing the vendor prefix before creating the next patch.
This will impact the driver also.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at