Re: [PATCH linux-next] mm/hugetlb: fix warning inalloc_huge_page/dequeue_huge_page_vma

From: David Rientjes
Date: Tue Apr 17 2012 - 16:25:44 EST


On Tue, 17 Apr 2012, Konstantin Khlebnikov wrote:

> This patch fixes gcc warning (and bug?) introduced in linux-next commit cc9a6c877
> ("cpuset: mm: reduce large amounts of memory barrier related damage v3")
>
> Local variable "page" can be uninitialized if nodemask from vma policy does not
> intersects with nodemask from cpuset. Even if it wouldn't happens it's better to
> initialize this variable explicitly than to introduce kernel oops on weird corner case.
>
> mm/hugetlb.c: In function âalloc_huge_pageâ:
> mm/hugetlb.c:1135:5: warning: âpageâ may be used uninitialized in this function
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxx>
> Cc: Mel Gorman <mgorman@xxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

This isn't just in -next, it's also in Linus' tree and seems like 3.4-rc4
material to me.