Re: [PATCH 2/3] pinctrl: pinctrl-imx: add imx6q pinctrl driver

From: Stephen Warren
Date: Tue Apr 17 2012 - 16:12:51 EST

On 04/13/2012 10:18 AM, Dong Aisheng wrote:
> From: Dong Aisheng <dong.aisheng@xxxxxxxxxx>
> Signed-off-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>

> diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c

> static const struct of_device_id imx_pmx_dt_ids[] = {
> + { .compatible = "fsl,imx6q-iomuxc", .data = (void *) &imx6q_pinctrl_info, },
> +#endif
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, imx_pmx_dt_ids);

Sorry for the slow review.

Based on SPEAr pinctrl review comments, we shouldn't have a single
driver that knows about all the different SoCs that it could support,
but rather one driver per SoC, with each of those calling into some
utility code in the core driver to do all the probe/remove work.

For more details, see commit a4c0738 "pinctrl: tegra: refactor probe
handling" in
(in branch for-3.5/gpio-pinmux).
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at