Re: [PATCH v4 2/2] regulator: add device tree support for max8997

From: Mark Brown
Date: Tue Apr 17 2012 - 14:38:33 EST


On Wed, Apr 18, 2012 at 12:05:59AM +0530, Thomas Abraham wrote:
> On 28 March 2012 22:33, Karol Lewandowski <k.lewandowsk@xxxxxxxxxxx> wrote:

> >> +    For BUCK's:

No 's here, BTW.

> >  - EN32KHz_AP
> >  - EN32KHz_CP
> >  - ENVICHG
> >  - ESAFEOUT1
> >  - ESAFEOUT2
> >  - CHARGER
> >  - CHARGER_CV
> >  - CHARGER_TOPOFF

> > I wonder if these should be mentioned in documentation too.

> Yes, I missed the above regulators in the documentation. I have
> included them now and will resubmit this patch.

Please omit the clocks; these are obviously a bodge due to the inability
to support clocks off-SoC so we shouldn't be enshrining them in the
device tree bindings.

Attachment: signature.asc
Description: Digital signature