Re: [PATCH v3 1/3] USB: Add driver for NXP ISP1301 USB transceiver

[Arnd Bergmann]

On Tuesday 17 April 2012, Roland Stigge wrote:
> +static int match(struct device *dev, void *data)
> +{
> +       struct device_node *node = (struct device_node *)data;
> +       return dev->of_node == node ? 1 : 0;
> +}

One small correction: you should probably check if the device
is actually bound to isp1301_driver:

	return (dev->of_node == node) && (dev->driver == &isp1301_driver.driver);

Otherwise, the changes from last version look all good.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/