Re: linux-next: build failure after merge of the final tree(security tree related)

[Stephen Rothwell]

Hi James,

On Tue, 17 Apr 2012 11:33:26 +1000 (EST) James Morris <jmorris@xxxxxxxxx> wrote:
>
> On Mon, 16 Apr 2012, Will Drewry wrote:
> 
> > >> arch/powerpc/kernel/ptrace.c: In function 'do_syscall_trace_enter':
> > >> arch/powerpc/kernel/ptrace.c:1713:2: error: statement with no effect [-Werror=unused-value]
> > >> cc1: all warnings being treated as errors
> 
> Is this happening because of
> 
> 	#define secure_computing(x) 0
> 
> ?
>
> In any case, that should probably be a static inline.

That could well be so - sorry I missed that.  The failure was in an
allnoconfig build, so CONFIG_SECCOMP was off.

And yes, changing that to:

static inline int secure_computing(int this_syscall) { return 0; }

fixes the build problem.  So that is a better fix.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature