Re: [PATCH RFC] vfs: make fstatat retry on ESTALE errors fromgetattr call

From: Myklebust, Trond
Date: Mon Apr 16 2012 - 15:33:24 EST


On Mon, 2012-04-16 at 13:46 -0400, Jeff Layton wrote:
> The question about looping indefinitely really comes down to:
>
> 1) is a persistent ESTALE in conjunction with a successful lookup a
> situation that we expect to be temporary. i.e. will the admin at some
> point be able to do something about it? If not, then there's no point
> in continuing to retry. Again, this is a situation that *really* should
> not happen if the filesystem is doing the right thing.
>
> 2) If the admin can't do anything about it, is it reasonable to expect
> that users can send a fatal signal to hung applications if this
> situation occurs.
>
> We expect that that's ok in other situations to resolve hung
> applications, so I'm not sure I understand why it wouldn't be
> acceptable here...

There are definitely potentially persistent pathological situations that
the filesystem can't do anything about. If the point of origin for your
pathname (for instance your current directory in the case of a relative
pathname) is stale, then no amount of looping is going to help you to
recover.

--
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com

èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—