Re: Please fix or revert: [PATCH] checkpatch: add --strict testsfor braces, comments and casts

[David Miller]

From: Ingo Molnar <mingo@xxxxxxxxxx>
Date: Mon, 16 Apr 2012 11:17:20 +0200

> 
> This recent checkpatch commit, added in v3.4-rc1:
> 
>   aad4f6149831 checkpatch: add --strict tests for braces, comments and casts
> 
> made the default checkpatch run complain about the following 
> perfectly fine multi-line comment block:
> 
> +               rdp->qlen_lazy = 0;
> +               rdp->qlen = 0;
> +
> +               /*
> +                * Adopt all callbacks.  The outgoing CPU was in no shape
> +                * to advance them, so make them all go through a full
> +                * grace period.
> +                */
> +               *receive_rdp->nxttail[RCU_NEXT_TAIL] = rdp->nxtlist;
> 

I would like to formally propose that we change CodingStyle so that
our comments are of the form:

	/* XXX
	 * YYY
	 */

So that we can save one line of vertical space.

We've adopted this all across the networking, and the code looks a
lot nicer as well as allowing more actual code onto a single window
of text.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/