Re: [PATCH v2 1/3] USB: Add driver for NXP ISP1301 USB transceiver

From: Roland Stigge
Date: Mon Apr 16 2012 - 11:52:08 EST

On 04/16/2012 05:09 PM, Alan Stern wrote:
>> drivers/usb/Makefile | 5 ++
>> drivers/usb/misc/Kconfig | 12 ++++++
>> drivers/usb/misc/Makefile | 1
>> drivers/usb/misc/isp1301.c | 64 ++++++++++++++++++++++++++++++++++
>> include/linux/usb/isp1301.h | 82 ++++++++++++++++++++++++++++++++++++++++++++
> You know, drivers/usb/misc is meant for miscellaneous USB device
> drivers. Not for host or transceiver drivers.
> You should put the new file somewhere else. Maybe in the otg
> directory, although that may not be completely appropriate either.
> Maybe something under the host directory.

The driver is used by drivers in the following directories:

drivers/usb/host/ (ohci-nxp.c)
drivers/usb/otg/ (isp1301_omap.c)
drivers/usb/gadget/ (lpc32xx_udc.c)

So host/ and otg/ don't look much better.

Maybe one of (new):



Otherwise, I will put it in drivers/usb/otg/ even of it doesn't look
better to me but the chip is advertised as "OTG transceiver". ;-)

Thanks in advance,

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at