Re: [PATCH] mfd: fix modular builds of rc5t583 regulator support

From: Laxman Dewangan
Date: Mon Apr 16 2012 - 03:06:26 EST

On Monday 16 April 2012 09:38 AM, Paul Gortmaker wrote:
The combination of commit 1b1247dd75aa5cf5fae54a3bec7280046e9c7957

"mfd: Add support for RICOH PMIC RC5T583"

and commit 6ffc3270210efa2bea526953a142ffc908f5bd86

"regulator: Add support for RICOH PMIC RC5T583 regulator"

are causing the i386 allmodconfig builds to fail with this:

ERROR: "rc5t583_update" [drivers/regulator/rc5t583-regulator.ko] undefined!
ERROR: "rc5t583_set_bits" [drivers/regulator/rc5t583-regulator.ko] undefined!
ERROR: "rc5t583_clear_bits" [drivers/regulator/rc5t583-regulator.ko] undefined!
ERROR: "rc5t583_read" [drivers/regulator/rc5t583-regulator.ko] undefined!

and this:

ERROR: "rc5t583_ext_power_req_config" [drivers/regulator/rc5t583-regulator.ko] undefined!

For the 1st four, make the simple ops static inline, instead of
polluting the namespace with trivial exports. For the last one,

Signed-off-by: Paul Gortmaker<paul.gortmaker@xxxxxxxxxxxxx>

[ alternately, make REGULATOR_RC5T583 bool instead of tristate? ]

Why not export all require symbol from mfd core.
I am sending the patch to exporting all required apis. Please review.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at