Re: [PATCH v2 05/16] KVM: MMU: abstract spte write-protect

From: Xiao Guangrong
Date: Sun Apr 15 2012 - 23:27:51 EST


On 04/14/2012 10:26 AM, Takuya Yoshikawa wrote:

> On Fri, 13 Apr 2012 18:11:45 +0800
> Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx> wrote:
>
>> +/* Return true if the spte is dropped. */
>
> Return value does not correspond with the function name so it is confusing.
>


That is why i put comment here.

> People may think that true means write protection has been done.
>


You have a better name?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/