Re: [PATCH] block: mtip32xx: remove HOTPLUG_PCI_PCIE dependancy

From: Jens Axboe
Date: Wed Apr 11 2012 - 16:38:51 EST


On 2012-04-11 22:33, Asai Thambi S P wrote:
> On 4/11/2012 12:57 PM, Jens Axboe wrote:
>
>> On 2012-04-11 20:34, Greg KH wrote:
>>> This removes the HOTPLUG_PCI_PCIE dependency on the driver and makes it
>>> depend on PCI.
>>
>> I think it's an old dependency. I've built and run it here without as
>> well, and no functional issues either.
>>
>> Sam/Asai?
>>
>
>
> Both driver and device will work fine without PCIe hotplug dependency. This
> dependency is required for supporting surprise removal and surprise insertion
> of the device on systems with PCIe hotplug controller.

That goes for all devices, though. So I think we can safely remove this
dependency. Nobody should expect hotplug/removal to work, without
actually including that :-)

If you or Sam would formally ack the patch, then I'll add it to the
pending mtip32xx series.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/