Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN

[Sven Neumann]

Hi,

On 07.04.12 09:02, Dmitry Torokhov wrote:
> On Fri, Apr 06, 2012 at 10:40:07PM -0700, Olof Johansson wrote:
> > This seems to have been broken since 2010, so obviously noone actually
> > cares about the driver:
> >
> > make[4]: *** [drivers/input/touchscreen/eeti_ts.o] Error 1
> > drivers/input/touchscreen/eeti_ts.c: In function 'eeti_ts_irq_active':
> > drivers/input/touchscreen/eeti_ts.c:65:2: error: implicit declaration of function 'irq_to_gpio' [-Werror=implicit-function-declaration]
> >
> > irq_to_gpio isn't available on most platforms today, so the driver
> > will need some rework by someone who has hardware access and can test
> > (to make sure that, for example, switching to level interrupts and just
> > keep taking them while there's more to process works).
> >
> > I guess it could just be scheduled for removal, but let's start with
> > marking it CONFIG_BROKEN.
>
> Well, it probably works quite well on arches that do have irq_to_gpio(),
> let's ask Daniel and Sven if they still have this hardware and if they
> can try the patch below that implements what you suggested.

This hardware is still in use and we also still follow kernel 
development and try to update our customer devices to recent kernel 
versions regularly. Currently we are at 3.1.10 and the touchscreen works 
well with that. I'll try to update to a more recent kernel next week and 
will try your patch.


Regards, Sven

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/