Re: [PATCH v2] gpio: Device tree support for LPC32xx

From: Roland Stigge
Date: Sat Apr 07 2012 - 10:19:06 EST


On 07/04/12 15:50, Roland Stigge wrote:
> Hi Grant,
...

> Please consider how the groups are specified in
> drivers/gpio/gpio-lpc32xx.c. They each have different numbers of lines
> and GPIO / GPI / GPO functionality. So they also have different callback
> sets, and we need to do separate gpiochip_add()s which leads to the
> separate gpio-bank specifications in the dtsi file. Separate enabling of
> those banks via OF are a nice by-product.

And BTW: This also corresponds nicely with how the LPC32xx hardware
calls its GPIOs, e.g. GPO 3 for GPO #3 in the gpo group.

Thanks for considering,

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/