Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; useirq_alloc_desc() instead

From: Thomas Gleixner
Date: Fri Apr 06 2012 - 07:17:16 EST


On Fri, 6 Apr 2012, Andreas Schwab wrote:

> Grant Likely <grant.likely@xxxxxxxxxxxx> writes:
>
> > Can you attach console output logs for each of configs above and also
> > with NR_IRQS=128? That might give me some clues as to which specific
> > code is causing the issues.
>
> It really looks like the issue starts when irq_expand_nr_irqs is called
> the first time to make nr_irqs bigger than NR_IRQS.

And it looks like the irqdomain code is the real culprit.

void irq_set_virq_count(unsigned int count)
{
pr_debug("irq: Trying to set virq count to %d\n", count);

BUG_ON(count < NUM_ISA_INTERRUPTS);
if (count < NR_IRQS)
irq_virq_count = count;
}

That looks simply wrong.....

s/NR_IRQS/nr_irqs/ should do the trick.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/