Re: [PATCH] regulator: rc5t583: Simplify RC5T583_REG macro

From: Mark Brown
Date: Fri Apr 06 2012 - 04:51:15 EST


On Fri, Apr 06, 2012 at 11:03:36AM +0530, Laxman Dewangan wrote:

> I thought of doing this on my first patch and then thought that
> table should have all configuration picture rather than deriving
> from few parameters.
> If this is a good way then I will take care for my next PMIC driver
> development.

This way is good - if you look at for example the wm831x driver where
there's a bunch of regulators with the same register layout replicated
in different places in the chip all it does is specify the base for the
block when defining a regulator.

Attachment: signature.asc
Description: Digital signature