Re: [PATCH 2/2] IPC: message queue stealing feature introduced

From: Stanislav Kinsbursky
Date: Thu Apr 05 2012 - 06:54:12 EST


05.04.2012 03:12, Andrew Morton ÐÐÑÐÑ:

I'd be a bit more comfortable if there was some sign that other c/r
developers have reviewed and tested this and have successfully used it
in c/r operation testing?


We have a user-space test (part of our regression testing test suite) for this functionality. Thus we run this test very ofter.

We've been trying to isolate the c/r-specific functions inside #ifdef
CONFIG_CHECKPOINT_RESTORE, but this patch doesn't do that. I have been
encouraging this isolation so that people who aren't using c/r don't
have to carry the overhead it adds and so that we can more easily hunt
down and remove everything if the entire c/r project doesn't work out
successfully.


Sorry. I'll add this ifdef's and send rebased patch set once more.

This patch modifies the sys_msgrcv() API and so we should update the
manpage for that syscall. Please work with Michael on this.


Sure.

What does all the compat fiddling actually do? I guess it's needed for
checkpoint and restore of 32-bit userspace on 64-bit kernels? Does c/r
as a whole support that? It should. How well tested is this?


CRIU doesn't support 32-bit processes migration yet. But we are going to add this support in future.

--
Best regards,
Stanislav Kinsbursky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/