Re: [PATCH] umem: fix up unplugging.

From: Jens Axboe
Date: Wed Apr 04 2012 - 19:18:44 EST


On 2012-04-04 16:20, Tao Guo wrote:
> Hi Andrew,
>
> Thanks for your reply.
>
> Yes, without this patch the umem driver just doesn't work.
> It is a bug introduced by commit 7eaceaccab5f40bbfda044629a6298616aeaed50.
> In that patch, Jens removed the whole mm_unplug_device() function,
> which used to be
> the trigger to make umem start to work.

Hmm indeed, that's isn't terribly useful. Why aren't we just calling
activate_card() on addition of a bio?

But your patch looks fine too, if it's tested it beats what we have.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/