Re: [PATCH] sysctl: fix write access to dmesg_restrict/kptr_restrict

From: Richard Weinberger
Date: Wed Apr 04 2012 - 15:07:31 EST


On 04.04.2012 20:40, Kees Cook wrote:
Commit bfdc0b4 adds code to restrict access to dmesg_restrict,
however, it incorrectly alters kptr_restrict rather than
dmesg_restrict.

The original patch from Richard Weinberger
(https://lkml.org/lkml/2011/3/14/362) alters dmesg_restrict as
expected, and so the patch seems to have been misapplied.

This adds the CAP_SYS_ADMIN check to both dmesg_restrict and
kptr_restrict, since both are sensitive.

Reported-by: Phillip Lougher<plougher@xxxxxxxxxx>
Signed-off-by: Kees Cook<keescook@xxxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx

Acked-by: Richard Weinberger <richard@xxxxxx>

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/