Re: [PATCH] Prevent crash on missing sysfs attribute group

From: Eric W. Biederman
Date: Tue Apr 03 2012 - 19:19:16 EST


Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:

> On Tue, 2012-04-03 at 00:50 -0700, Eric W. Biederman wrote:
>>
>> So I am asking that since perf is built in a way that actively makes
>> debugging these kinds of problems hard that you please add additional
>> debugging code to perf_pmu_register or some other better location so
>> that simply registering something buggy with perf will show the bug.
>>
>>
> Is there a convenient helper function that we can use that validates the
> attribute_group structure? We could use such a function to do the
> validation at a point where we still know where it came from.

There isn't but I was just thinking before you sent this that we could
really use one.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/