Re: [PATCH] tilepro ethernet driver: fix a few minor issues

[David Miller]

From: Chris Metcalf <cmetcalf@xxxxxxxxxx>
Date: Fri, 30 Mar 2012 19:23:35 -0400

> This commit fixes a number of issues seen with the driver:
> 
> - Improve handling of return credits to the hardware shim
> - Use skb_frag_size() appropriately
> - Add netpoll support to run console over UDP
> 
> Signed-off-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>

Please do not mix pure bug fixes and new features.

Submit the pure bug fixes separately for 'net' tree submission
and then submit feature additions like netpoll support in
a patch targetting the 'net-next' tree.

> +	/* Handle completions if needed to make room. */
> +	/* NOTE: Return NETDEV_TX_BUSY if there is still no room. */

Do not format comments like this, use something like this instead:

	/* Handle completions if needed to make room.
	 * NOTE: Return NETDEV_TX_BUSY if there is still no room.
	 */

>  	/* Prepare to advance, detecting full queue. */
> +	/* NOTE: Return NETDEV_TX_BUSY if the queue is full. */

Similarly, combine them up into a single comment.

> +	/* Handle completions if needed to make room. */
> +	/* NOTE: Return NETDEV_TX_BUSY if there is still no room. */

Same here.

>  	/* Copy the commands, or fail. */
> +	/* NOTE: Return NETDEV_TX_BUSY if the queue is full. */

Again.

> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +/*
> + * Polling 'interrupt' - used by things like netconsole to send skbs

Format the comment:

	/* Like
	 * this.
	 */

not:

	/*
	 * Like
	 * this.
	 */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/