Re: [PATCH] printk(): add KERN_CONT where needed

[Joe Perches]

On Tue, 2012-04-03 at 18:20 +0200, Kay Sievers wrote:
> On Tue, Apr 3, 2012 at 18:16, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > Conversations happen all over the place and making
> > separate discussions isn't that valuable nor are
> > they really controllable.
> 
> Sure, but this is not a conversation in that sense, you reply to a
> patch that something is not correct, but what's not correct is not a
> subject of the patch. And that I need to correct.
> 
> > Just write the change log to simply state "add KERN_CONT"
> > without mentioning your unpublished stuff.
> 
> The changelog says:
> 
> "A prototype for kmsg records instead of a byte-stream buffer revealed
> a couple of missing printk(KERN_CONT ...) uses. Subsequent calls produce
> one record per printk() call, while all should have ended up in a single
> record."
> 
> What else do you need?

You need less.

This has nothing to do with the current printk subsystem,
it has only to do with using KERN_CONT.

Maybe:

trivial: add some KERN_CONT markers to continuation lines

or something like:

commit 66d0ae4d6ffa45b8e6d8bdbf85f8f1b285c8152d
Author: Jiri Slaby <jirislaby@xxxxxxxxx>
Date:   Sun Dec 6 16:16:24 2009 +0100

    PM / Hibernate: Swap, use KERN_CONT
    
    Use KERN_CONT in save_image() for printks, so that anybody won't
    try to add a loglevel.
    
    Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
    Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/