Re: [PATCH 02/69] TTY: crisv10, initialize tty_port

From: Jesper Nilsson
Date: Tue Apr 03 2012 - 07:47:30 EST


On Mon, Apr 02, 2012 at 01:53:46PM +0200, Jiri Slaby wrote:
> The tty_port used in the driver is left uninitialized. Add the
> initialization there.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Mikael Starvik <starvik@xxxxxxxx>

Looks good!

Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>

> Cc: linux-cris-kernel@xxxxxxxx
> ---
> drivers/tty/serial/crisv10.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c
> index 004ee2e..80b6b1b 100644
> --- a/drivers/tty/serial/crisv10.c
> +++ b/drivers/tty/serial/crisv10.c
> @@ -4462,6 +4462,7 @@ static int __init rs_init(void)
> info->enabled = 0;
> }
> }
> + tty_port_init(&info->port);
> info->uses_dma_in = 0;
> info->uses_dma_out = 0;
> info->line = i;
> --
> 1.7.9.2
>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/