Re: [PATCH 18/21] blkcg: move blkio_group_conf->weight to cfq

[Tejun Heo]

Hello,

On Tue, Apr 03, 2012 at 05:39:23AM +0800, Tao Ma wrote:
> I guess blkio->weight is a generic way of abstracting the weight between
> different block cgroups.

It isn't and can't be.  There's nothing generic about it across
different policies and it's not even clear what that means.  If the
user chooses combine, iops limit with cfq weights, what the hell is
"generic" about that weight?

> Yes, currently, only cfq uses it, but I am
> trying to improve Shaohua's original fiops scheduler and add cgroup
> support to it. So please leave it there so that future scheduler(if
> other than the fiops scheduler) can use the framework.

So, if you want to implement a new blkcg policy, add the config
parameters and export the stats the policy wants *yourself*.  Not
having clear separation between policies and generic stuff was what
led us to this yucky mess and there's no way we're going back there.
So, NO.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/