Re: [PATCH] phonet: Check input from user before allocating

From: David Miller
Date: Mon Apr 02 2012 - 17:41:17 EST


From: "Rémi Denis-Courmont" <remi@xxxxxxxxxx>
Date: Mon, 2 Apr 2012 22:01:40 +0300

> Le lundi 2 avril 2012 23:31:00 Sasha Levin, vous avez écrit :
>> A phonet packet is limited to USHRT_MAX bytes, this is never checked during
>> tx which means that the user can specify any size he wishes, and the kernel
>> will attempt to allocate that size.
>
> Does this really solve the problem? I guess 128kb is still possible with
> USHRT_MAX plus skbuff overhead, which might still trigger OOM relatively
> easily once the memory gets sufficiently fragmented.
>
> How does UDP deal with this?

UDP generates a fragment list of MTU sized SKBs.

Phonet could avoid the large allocations by building page based
SKBs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/