Re: [PATCH 58/76] idle, x86: Allow off-lined CPU to enter deeper Cstates

From: Konrad Rzeszutek Wilk
Date: Mon Apr 02 2012 - 13:50:37 EST


On Mon, Apr 02, 2012 at 10:25:27AM -0700, Tony Luck wrote:
> >> +       while (1) {
> >> +
> >> +               if (cx->entry_method == ACPI_CSTATE_HALT)
> >> +                       halt();
>
> What's the intent here? I think that I can just set up a function pointer
> named "halt" on ia64 and point it to my cpu_halt() function (which looks
> for the deepest C-state, and then calls PAL to enter it. Is that equivalent
> to what the x86 "halt()" function does?

Or use the appropiate safe_halt() which should work on IA64.

>
> -Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/