Re: [PATCH 01/19 v2] avr32/mm/fault.c: Port OOM changes to do_page_fault

From: Kautuk Consul
Date: Mon Apr 02 2012 - 11:30:22 EST


>
> Looks very good, thanks.
>
>> @@ -122,6 +124,7 @@ good_area:
>>                if (!(vma->vm_flags & VM_WRITE))
>>                        goto bad_area;
>>                writeaccess = 1;
>> +               flags |= FAULT_FLAG_WRITE;
>
> Could you remove the 'writeaccess' variable as well? It looks unused
> after applying your patch.

Sure, Ill do that and send v2.1 of this patch to you.

>
> Ug...the avr32 arch is in a terrible state. Someone appears to have
> removed the atmel_nand driver...

I don't know anything about that. :)

>
> Havard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/