sendmmsg: put_user vs __put_user

From: Ulrich Drepper
Date: Fri Mar 30 2012 - 09:36:44 EST


Shouldn't the compat code in the sendmmsg implementation use the same
code as the normal code? In which case you probably want something
like this:

diff --git a/net/socket.c b/net/socket.c
index 484cc69..ff40409 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -2064,7 +2064,7 @@ int __sys_sendmmsg(int fd, struct mmsghdr __user
*mmsg, unsigned int vlen,
&msg_sys, flags, &used_address);
if (err < 0)
break;
- err = __put_user(err, &compat_entry->msg_len);
+ err = put_user(err, &compat_entry->msg_len);
++compat_entry;
} else {
err = __sys_sendmsg(sock, (struct msghdr __user *)entry,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/