RE: [PATCH v3] regulator: Add TPS65090 regulator driver

From: Venu Byravarasu
Date: Sun Mar 25 2012 - 23:53:18 EST


> >
> > TPS65090 PMIC from TI consists of 3 step down converters,
> > 2 always on LDOs and 7 current limited load switches. The
> > output voltages are ON/OFF controllable and are meant to
> > supply power to the components on target board.
>
> Applied, but...
>
> > + rdev = regulator_register(&ri->desc, &pdev->dev,
> > + &tps_pdata->regulator, ri, NULL);
> > + if (IS_ERR_OR_NULL(rdev)) {
>
> ...please submit an incremental patch changing this to plain IS_ERR(),
> regulator_register() only returns error pointers. Note that no other
> regulator drivers do this check.
Thanks Mark, for applying this patch.
As Axel already provided a patch to fix this, Acked on his patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/