Re: [PATCH 7/9] omap2plus: ensure that one of omap2/3/4 is selected

From: Tony Lindgren
Date: Fri Mar 23 2012 - 13:28:47 EST


* mathieu.poirier@xxxxxxxxxx <mathieu.poirier@xxxxxxxxxx> [120323 10:16]:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Random configurations can fail if none of the omap families
> in mach-omap2 is selected. This patch automatically selects
> omap2 if the user has not made any other choice.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
> arch/arm/mach-omap2/Kconfig | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 0279e9e..b244e80 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -55,6 +55,16 @@ config ARCH_OMAP4
> select USB_ARCH_HAS_EHCI
> select ARM_CPU_SUSPEND if PM
>
> +config ARCH_OMAP2_AUTO
> + bool
> + depends on !ARCH_OMAP3 && !ARCH_OMAP4
> + select ARCH_OMAP2
> + default y
> + help
> + At least one of OMAP2/OMAP3/OMAP4 needs to be enabled, this
> + selects OMAP2 if nothing else gets selected, to avoid non-building
> + configurations.
> +
> comment "OMAP Core Type"
> depends on ARCH_OMAP2

Hmm yeah omap2 makes the smallest build, so randconfig builds
faster than it would for omap3 or 4.

But isn't there now still a chance that randconfig does not
select ARCH_OMAP2_AUTO either?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/