Re: [PATCH V2] x86: io_apic: Move and reenable irq only whenCONFIG_GENERIC_PENDING_IRQ=y

[Ingo Molnar]

* Alexander Gordeev <agordeev@xxxxxxxxxx> wrote:

> On Fri, Mar 23, 2012 at 01:35:03PM +0100, Ingo Molnar wrote:
> > 
> > * Alexander Gordeev <agordeev@xxxxxxxxxx> wrote:
> > 
> > > When CONFIG_GENERIC_PENDING_IRQ=n irq move and reenable code 
> > > is never get executed, nor do_unmask_irq variable updates its 
> > > init value. Move the code under CONFIG_GENERIC_PENDING_IRQ 
> > > macro.
> > 
> > It's not clear from the changelog what it does though, and the
> > #ifdefs are quite a mess. Does the patch fix some real bug? Or 
> > does it remove dead code from certain .config variations?
> 
> It just removes a dead code. Can reword if it worth it.

No need to resend, I'll add this detail.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/