Re: [PATCH] gianfar: Fix possible overrun and simplify interruptname field creation

From: David Miller
Date: Thu Mar 22 2012 - 23:34:33 EST


From: David Miller <davem@xxxxxxxxxxxxx>
Date: Wed, 21 Mar 2012 22:34:57 -0400 (EDT)

> From: Joe Perches <joe@xxxxxxxxxxx>
> Date: Sat, 17 Mar 2012 12:05:38 -0700
>
>> Space allocated for int_name_<foo> is unsufficient for
>> maximal device name, expand it.
>>
>> Code to create int_name_<foo> is obscure, simplify it
>> by using sprintf.
>>
>> Found by looking for unnecessary \ line continuations.
>> Uncompiled, untested.
>>
>> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
>
> Can a gianfar expert please review and test this patch?

If you gianfar guys don't show a sign of life in the next 24 hours I'm
just going to apply Joe's patch as-is. I refuse to just let it rot in
patchwork like this.

And then you don't get to complain if his change breaks your driver
because I asked multiple times for testing and/or review.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/