Re: [PATCH v1 1/9] ext4: do not mark superblock as dirtyunnecessarily

[Jan Kara]

On Tue 20-03-12 16:41:21, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
> 
> Commit a0375156ca1041574b5d47cc7e32f10b891151b0 cleaned up superblock dirtying
> handling, but missed one place. This patch does what was intended: if we have
> the journal, then we update the superblock through the journal rather than
> doing this directly.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
  Looks OK.
Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza
> ---
>  fs/ext4/inode.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index feaa82f..e040403 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3924,10 +3924,8 @@ static int ext4_do_update_inode(handle_t *handle,
>  			ext4_update_dynamic_rev(sb);
>  			EXT4_SET_RO_COMPAT_FEATURE(sb,
>  					EXT4_FEATURE_RO_COMPAT_LARGE_FILE);
> -			sb->s_dirt = 1;
>  			ext4_handle_sync(handle);
> -			err = ext4_handle_dirty_metadata(handle, NULL,
> -					EXT4_SB(sb)->s_sbh);
> +			err = ext4_handle_dirty_super(handle, sb);
>  		}
>  	}
>  	raw_inode->i_generation = cpu_to_le32(inode->i_generation);
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/