Re: [PATCH 3/4] clk: Provide dummy clk_unregister()

From: Turquette, Mike
Date: Wed Mar 21 2012 - 16:37:05 EST


On Wed, Mar 21, 2012 at 1:01 PM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> While there's no actual implementation behind it having the call to use
> in drivers makes them feel neater from a driver author point of view. An
> actual implementation can wait for someone who needs to use the function
> in a real system.

Thanks for the patch Mark. I'll include this in my fixes branch.

Regards,
Mike

> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/clk/clk.c            |   12 ++++++++++++
>  include/linux/clk-provider.h |    1 +
>  2 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 33ef0df..31419ca 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -1344,6 +1344,18 @@ struct clk *clk_register(struct device *dev, const char *name,
>  }
>  EXPORT_SYMBOL_GPL(clk_register);
>
> +/**
> + * clk_unregister - unregister a currently registered clock
> + * @clk: clock to unregister
> + *
> + * Currently unimplemented.
> + */
> +int clk_unregister(struct clk *clk)
> +{
> +       return -EINVAL;
> +}
> +EXPORT_SYMBOL_GPL(clk_unregister);
> +
>  /***        clk rate change notifiers        ***/
>
>  /**
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index 340acbc..57c0bd1 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -275,6 +275,7 @@ struct clk *clk_register_mux(struct device *dev, const char *name,
>  struct clk *clk_register(struct device *dev, const char *name,
>                const struct clk_ops *ops, struct clk_hw *hw,
>                const char **parent_names, u8 num_parents, unsigned long flags);
> +int clk_unregister(struct clk *clk);
>
>  /* helper functions */
>  const char *__clk_get_name(struct clk *clk);
> --
> 1.7.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/