Re: [PATCH 3/3] xen/x86: Implement x86_apic_ops

[Suresh Siddha]

On Wed, 2012-03-21 at 12:41 -0400, Konrad Rzeszutek Wilk wrote:
> > > +unsigned int xen_io_apic_read(unsigned apic, unsigned reg)
> > > +{
> > > +	if (reg == 0x1)
> > > +		return 0x00170020;
> > > +	else if (reg == 0x0)
> > > +		return 0x00000000;
> > 
> > For IO-APIC ID register (0), you can probably use the argument 'apic' to
> > set the ID bits in the returned register.
> 
> ok, that would be just
> return 0x0000000 | apic
> 
> right? Since the last 8 bits are the apic value?

It is the most significant 8 bits.

So you need to return (apic << 24);

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/