Re: [PATCH] dma: imx-sdma: Treat firmware messages as warningsinstead of erros

From: Vinod Koul
Date: Wed Mar 21 2012 - 06:05:23 EST


On Thu, 2012-03-08 at 09:26 -0300, Fabio Estevam wrote:
> As the SDMA controller can operate without an external firmware being loaded,
> treat the firmware related messages as warnings rather than errors.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
Applied Thanks
> ---
> drivers/dma/imx-sdma.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c495882..3b7ebd4 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1389,7 +1389,7 @@ static int __init sdma_probe(struct platform_device *pdev)
> if (pdata) {
> ret = sdma_get_firmware(sdma, pdata->fw_name);
> if (ret)
> - dev_err(&pdev->dev, "failed to get firmware from platform data\n");
> + dev_warn(&pdev->dev, "failed to get firmware from platform data\n");
> } else {
> /*
> * Because that device tree does not encode ROM script address,
> @@ -1399,11 +1399,11 @@ static int __init sdma_probe(struct platform_device *pdev)
> ret = of_property_read_string(np, "fsl,sdma-ram-script-name",
> &fw_name);
> if (ret)
> - dev_err(&pdev->dev, "failed to get firmware name\n");
> + dev_warn(&pdev->dev, "failed to get firmware name\n");
> else {
> ret = sdma_get_firmware(sdma, fw_name);
> if (ret)
> - dev_err(&pdev->dev, "failed to get firmware from device tree\n");
> + dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
> }
> }
>


--
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/