Re: [PATCH] kdb: Add message about CONFIG_DEBUG_RODATA on failureto install breakpoint

[Tim Bird]

On 03/20/2012 11:32 AM, Jason Wessel wrote:
> On 09/21/2011 03:07 PM, Tim Bird wrote:
>> On x86, if CONFIG_DEBUG_RODATA is set, one cannot set breakpoints
>> via KDB.  Apparently this is a well-known problem, as at least one distribution
>> now ships with both KDB enabled and CONFIG_DEBUG_RODATA=y for security reasons.
>>
>> This patch just adds an extra printk message to the breakpoint failure case,
>> in order to provide some useful diagnostics to the user.
>>
> 
> The patch is definitely the right idea.  I believe we should try and tell the whole story and only print the message for the type of breakpoint that fails.  It is absolutely the case that you can still use kdb/kdb without recompiling the kernel.
> 
> I propose a slightly different implementation below.

The new patch looks fine.
 -- Tim

=============================
Tim Bird
Architecture Group Chair, CE Workgroup of the Linux Foundation
Senior Staff Engineer, Sony Network Entertainment
=============================

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/