Re: [PATCH 2/4] compat: backport work_busy()

[Luis R. Rodriguez]

On Tue, Mar 20, 2012 at 5:07 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2012-03-19 at 20:26 -0700, Luis R. Rodriguez wrote:
>> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxx>
>>
>> Best we can do is just tell the users of we are WORK_BUSY_PENDING
>> for older kernels. The ckmake log:
>
> [...]
>
>> + * Test whether @work is currently pending or running. ÂThere is no
>> + * synchronization around this function and the test result is
>> + * unreliable and only useful as advisory hints or for debugging.
>> + * Especially for reentrant wqs, the pending state might hide the
>> + * running state.
>
> What's this needed for? It seems if it's used only for hints/debugging
> we should not need the function, or possibly simply return some
> pointless combination like -1?

net/bluetooth/hci_core.c:1701:	if (work_busy(&hdev->le_scan))

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/