Re: linux-next: build warning after merge of the nfs tree

From: Myklebust, Trond
Date: Tue Mar 20 2012 - 09:29:03 EST


On Tue, 2012-03-20 at 19:34 +1100, Stephen Rothwell wrote:
> Hi Trond,
>
> After merging the nfs tree, today's linux-next build (sparc32 defconfig)
> produced this warning:
>
> net/sunrpc/rpcb_clnt.c: In function 'rpcb_enc_mapping':
> net/sunrpc/rpcb_clnt.c:820:19: warning: unused variable 'task' [-Wunused-variable]
> net/sunrpc/rpcb_clnt.c: In function 'rpcb_dec_getport':
> net/sunrpc/rpcb_clnt.c:837:19: warning: unused variable 'task' [-Wunused-variable]
> net/sunrpc/rpcb_clnt.c: In function 'rpcb_dec_set':
> net/sunrpc/rpcb_clnt.c:860:19: warning: unused variable 'task' [-Wunused-variable]
> net/sunrpc/rpcb_clnt.c: In function 'rpcb_enc_getaddr':
> net/sunrpc/rpcb_clnt.c:892:19: warning: unused variable 'task' [-Wunused-variable]
> net/sunrpc/rpcb_clnt.c: In function 'rpcb_dec_getaddr':
> net/sunrpc/rpcb_clnt.c:914:19: warning: unused variable 'task' [-Wunused-variable]
> fs/lockd/svclock.c:49:20: warning: 'nlmdbg_cookie2a' declared 'static' but never defined [-Wunused-function]
>
>
> Probably caused by some debugging being turned off.

Yes, this is due to the new CONFIG_SUNRPC_DEBUG being turned off. The
issue has in fact been in the tree for quite a while, but before we
added the explicit Kbuild switch, you had to have SUNRPC enabled, while
disabling SYSCTL in order to see it.

Anyhow, I've added a fix. Thanks for the report!

Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com

èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—