Re: [PATCH/RFC] dmaengine: add a slave parameter to__dma_request_channel()

From: Vinod Koul
Date: Tue Mar 20 2012 - 03:07:53 EST


On Mon, 2012-03-19 at 17:32 +0100, Guennadi Liakhovetski wrote:
> Sure. In the datasheet we have: to configure a channel for client 1 write
> value X to register A and value Y to register B. That's it. One of them is
> really just a magic slave ID. Another one has several fields with values
> like bus width and transfer size. They could be passed "properly," but
> since those fields also vary between DMAC versions, it is easier to just
> fix the whole register value per client and pass it from the platform
> data. In any case, at least the slave ID is really just a constant, that
> cannot be calculated and has to be passed from platform data.
I think I like the idea of having the these slave IDs coming from
platform map. That way drivers can be agnostic...

--
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/